Don't update the ratelimits if we got a response from a cache #2273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2273 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 115 115
Lines 10360 10363 +3
=======================================
+ Hits 10136 10139 +3
Misses 156 156
Partials 68 68
Continue to review full report at Codecov.
|
The recommended cache, https://github.com/gregjones/httpcache, returns an X-From-Cache: 1 header whenever it serves a response from the cache. Cached responses might include (possibly stale) ratelimit headers, which we would've already processed in the past.
155f27f to
2b58fd7
Compare
|
Thanks for the quick review :) Added tests, rebased to master, signed the CLA. |
|
Thank you, @raynigon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recommended cache, https://github.com/gregjones/httpcache, returns
an X-From-Cache: 1 header whenever it serves a response from the cache.
Cached responses might include (possibly stale) ratelimit headers, which
we would've already processed in the past.