+
Skip to content

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented May 7, 2021

Fixes: #1865.

Note that this should not be a breaking API change if I'm not mistaken.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label May 7, 2021
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #1870 (4ba396a) into master (a19996a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1870   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         105      105           
  Lines        6771     6771           
=======================================
  Hits         6612     6612           
  Misses         86       86           
  Partials       73       73           
Impacted Files Coverage Δ
github/repos.go 98.70% <ø> (ø)
github/teams.go 98.09% <ø> (ø)
github/users.go 94.73% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a19996a...4ba396a. Read the comment docs.

@gmlewis gmlewis requested a review from wesleimp May 7, 2021 14:07
Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@gmlewis
Copy link
Collaborator Author

gmlewis commented May 12, 2021

Thank you, @wesleimp !
Merging.

@gmlewis gmlewis merged commit 77a5f59 into google:master May 12, 2021
@gmlewis gmlewis deleted the i1865-remove-pointers-to-maps branch May 12, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change all *map... to map... in JSON structs

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载