Add missing CreatedAt field in users_keys class
#1256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1256 +/- ##
=======================================
Coverage 73.42% 73.42%
=======================================
Files 86 86
Lines 6040 6040
=======================================
Hits 4435 4435
Misses 836 836
Partials 769 769
Continue to review full report at Codecov.
|
gmlewis
requested changes
Aug 21, 2019
There was a problem hiding this comment.
Thank you, @simonkey007!
Just one comment to address, please, then I believe that we can merge.
github/users_keys.go
Outdated
| URL *string `json:"url,omitempty"` | ||
| Title *string `json:"title,omitempty"` | ||
| ReadOnly *bool `json:"read_only,omitempty"` | ||
| CreatedAt *time.Time `json:"created_at,omitempty"` |
There was a problem hiding this comment.
I believe we have decided to make new time values be of type Timestamp.
Could you please change this from *time.Time to *Timestamp?
There was a problem hiding this comment.
@gmlewis I've changed type of CreatedAt to *Timestamp
gmlewis
approved these changes
Aug 21, 2019
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.