+
Skip to content

fix GetProjectCard Argument #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

ainoya
Copy link
Contributor

@ainoya ainoya commented Jul 24, 2019

https://developer.github.com/v3/projects/cards/#get-a-project-card

correct argument name because this api accepts card_id, not column_id

GET /projects/columns/cards/:card_id

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jul 24, 2019
@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #1239 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1239   +/-   ##
=======================================
  Coverage   73.36%   73.36%           
=======================================
  Files          86       86           
  Lines        6026     6026           
=======================================
  Hits         4421     4421           
  Misses        836      836           
  Partials      769      769
Impacted Files Coverage Δ
github/projects.go 66.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c756c32...805cc58. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ainoya!

LGTM.
Merging.

@gmlewis gmlewis merged commit 4c1ec01 into google:master Jul 25, 2019
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载