+
Skip to content

Fix ineffectual assignments and error handling in tests #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2019

Conversation

muesli
Copy link
Contributor

@muesli muesli commented Jul 19, 2019

  • Ignore ineffectual assignments
  • Check for error when reading keyring

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jul 19, 2019
@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #1234 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1234   +/-   ##
=======================================
  Coverage   73.36%   73.36%           
=======================================
  Files          86       86           
  Lines        6026     6026           
=======================================
  Hits         4421     4421           
  Misses        836      836           
  Partials      769      769

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 955a14c...ca507d0. Read the comment docs.

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 19, 2019

Thanks, @muesli - I'm the one that wrote these additional tests for the sake of code coverage improvements. If you're going to do this, please go through and fix all the added code coverage tests so that the repo is self-consistent in style.

@muesli
Copy link
Contributor Author

muesli commented Jul 19, 2019

@gmlewis I don't think it would affect code coverage, but I'm happy to remove the other ineffectual assignments I can find.

- Ignore ineffectual assignments
- Check for error when reading keyring
@muesli
Copy link
Contributor Author

muesli commented Jul 20, 2019

@gmlewis Ok, hope I caught them all.

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 20, 2019

OK, looks like these changes did not affect code coverage, and my original PRs were done to improve coverage (without review), so I'm just going to go ahead and merge this as a code cleanup.
Thanks, @muesli.

@gmlewis gmlewis merged commit c756c32 into google:master Jul 20, 2019
@muesli
Copy link
Contributor Author

muesli commented Jul 20, 2019

No problem, thanks for merging!

n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载