+
Skip to content

addOptions to list gists forks endpoint #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

srivignessh
Copy link
Contributor

Added test cases to increase coverage

Added Test cases to increase coverage
@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jul 11, 2019
@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #1229 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1229      +/-   ##
==========================================
+ Coverage   73.28%   73.36%   +0.07%     
==========================================
  Files          86       86              
  Lines        6023     6026       +3     
==========================================
+ Hits         4414     4421       +7     
+ Misses        838      836       -2     
+ Partials      771      769       -2
Impacted Files Coverage Δ
github/gists.go 77.48% <100%> (+3.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad32f2...5c17575. Read the comment docs.

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 11, 2019

Thank you, @srivignessh. I have a pro-tip for you. Instead of opening and closing multiple PRs until you get all the details perfect (thus artificially bumping up this repo's overall PR count), you can leave the one PR open and commit more changes to it and the tools will rerun tests after each additional commit push.

That has the added benefit that it will reduce all the emails being sent to the (currently) 177 people who are watching this repo. Thanks!

Are you ready to have this PR reviewed?

@srivignessh
Copy link
Contributor Author

Thank you, @gmlewis

I will follow your advice and update the existing PRs with updated commits.
I apologize for the opening and closing multiple PRs
.
Yes, I am ready to get the PR reviewed.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @srivignessh!
LGTM.

Awaiting second LGTM before merging.

Note to self: this is a breaking API change, so we will need to bump the major version after this merge.

@gmlewis gmlewis requested a review from gauntface July 11, 2019 23:57
Copy link
Contributor

@gauntface gauntface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR :)

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 16, 2019

Thank you, @gauntface!
Merging, then bumping major version.

@gmlewis gmlewis merged commit fddcd13 into google:master Jul 16, 2019
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载