-
Notifications
You must be signed in to change notification settings - Fork 2.1k
addOptions to list gists forks endpoint #1229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addOptions to list gists forks endpoint #1229
Conversation
Added Test cases to increase coverage
Codecov Report
@@ Coverage Diff @@
## master #1229 +/- ##
==========================================
+ Coverage 73.28% 73.36% +0.07%
==========================================
Files 86 86
Lines 6023 6026 +3
==========================================
+ Hits 4414 4421 +7
+ Misses 838 836 -2
+ Partials 771 769 -2
Continue to review full report at Codecov.
|
Thank you, @srivignessh. I have a pro-tip for you. Instead of opening and closing multiple PRs until you get all the details perfect (thus artificially bumping up this repo's overall PR count), you can leave the one PR open and commit more changes to it and the tools will rerun tests after each additional commit push. That has the added benefit that it will reduce all the emails being sent to the (currently) 177 people who are watching this repo. Thanks! Are you ready to have this PR reviewed? |
Thank you, @gmlewis I will follow your advice and update the existing PRs with updated commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @srivignessh!
LGTM.
Awaiting second LGTM before merging.
Note to self: this is a breaking API change, so we will need to bump the major version after this merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR :)
Thank you, @gauntface! |
Added test cases to increase coverage