+
Skip to content

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Aug 5, 2018

Fixes #963.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Aug 5, 2018
@gmlewis
Copy link
Collaborator Author

gmlewis commented Aug 5, 2018

Hmmm... Go 1.7 does not have url.PathEscape apparently.
Shall we stop supporting Go 1.7 ?

@gmlewis
Copy link
Collaborator Author

gmlewis commented Aug 5, 2018

@willnorris, @dmitshur, @juliaferraioli - I'm considering removing support for Go 1.7 for this repo due to it missing url.PathEscape...
Are there any objections?

@gmlewis gmlewis mentioned this pull request Aug 5, 2018
@gmlewis gmlewis requested a review from juliaferraioli August 7, 2018 01:56
Copy link
Contributor

@juliaferraioli juliaferraioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gmlewis!

@gmlewis
Copy link
Collaborator Author

gmlewis commented Aug 8, 2018

Thank you, @juliaferraioli!
Merging.

@gmlewis gmlewis merged commit 8c40ff4 into google:master Aug 8, 2018
@gmlewis gmlewis deleted the search-query-escape branch August 8, 2018 17:56
gmlewis added a commit to gmlewis/go-github that referenced this pull request Aug 10, 2018
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载