+
Skip to content

Fix handling of redirected URLs in OnResponseHeaders #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2020
Merged

Fix handling of redirected URLs in OnResponseHeaders #561

merged 1 commit into from
Nov 30, 2020

Conversation

WGH-
Copy link
Collaborator

@WGH- WGH- commented Nov 24, 2020

When OnResponse callback is called, the request URL is updated to reflect the redirect that has been followed (if any).

Do the same for OnResponseHeaders, for consistency.

@WGH-
Fix handling of redirected URLs in OnResponseHeaders
bc1e233 
When OnResponse callback is called, the request URL is updated to
reflect the redirect that has been followed (if any).

Do the same for OnResponseHeaders, for consistency.
asciimoo
asciimoo approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@asciimoo asciimoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, thanks!

@asciimoo asciimoo merged commit 8b8d89a into gocolly:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asciimoo asciimoo asciimoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WGH- @asciimoo
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载