+
Skip to content

feat: support Stop() in queue #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Conversation

PalanQu
Copy link
Contributor

@PalanQu PalanQu commented Aug 22, 2020

Add feature #528 . @asciimoo

@asciimoo
Copy link
Member

It would be nice to have an option to resume after calling Stop().

@PalanQu
Copy link
Contributor Author

PalanQu commented Sep 3, 2020

It would be nice to have an option to resume after calling Stop().

@asciimoo Is there any idea about how to resume after calling Stop()?

@asciimoo
Copy link
Member

asciimoo commented Sep 8, 2020

@PalanQu what about adding a Resume() function which sets running = true and calls Run()? Or, we can modify Run() to be able to call it again by setting running = true in it.

@PalanQu
Copy link
Contributor Author

PalanQu commented Sep 8, 2020

@PalanQu what about adding a Resume() function which sets running = true and calls Run()? Or, we can modify Run() to be able to call it again by setting running = true in it.

@asciimoo Thx, I will try.

@PalanQu
Copy link
Contributor Author

PalanQu commented Sep 12, 2020

@asciimoo Hi, I modified the Run() function, please help me to review this PR, thx.

Copy link
Member

@asciimoo asciimoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@asciimoo asciimoo merged commit 8224eca into gocolly:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载