add generated completions for shells #34973
Conversation
since flags aren't marked as local they cascade through the app so before can be used as setup as we need to define flags once.
only main and it's subcommands are directly handled by it
instead of looping though the flags in linage, use their non local property
add fish to docs
cmd/main.go
Outdated
| for i := range command.Commands { | ||
| prepareSubcommandWithGlobalFlags(command.Commands[i]) | ||
| } | ||
| command.Before = prepareWorkPathAndCustomConf() |
There was a problem hiding this comment.
Is this comment resolved?
There was a problem hiding this comment.
in short: Yes.
for background context - flags are persistent in v3 by default meaning if you define a flag at (gitea) level, then the (gitea actions) command also has it. To opt out of this you have to mark the flag as local in it's definition.
This doesn't matter for flags which are attached to final command of course as the flag has nowhere to propagate to.
Removing the loop removes the cascading issue so the setup is done only once and flags still propagate (as they aren't marked as local). This can be verified by adding a print in the function and running any nested command.
But this made me catch that i'm overwriting the original before function which I've patched just now.
add makefile rule for shell completions, disable internal commands from showing in help
rework custom help so it only triggers on first level commands
help changes are mainly to work around regression: #34510 (comment)