Tags: go-nv/goenv
Tags
Don't suggest adding GOROOT/bin and GOPATH/bin to the PATH. (#463) The installation instructions say to make the shell init script execute the output of `goenv init -`. That output contains this among other things: ``` export PATH="${GOENV_ROOT}/shims:${PATH}" ``` The main point of that line is to make the `go` command resolve to `$GOENV_ROOT/shims/go` such that `goenv` has control over the default `go`. The installation instructions later say to add this after the eval in order to let "goenv manage GOPATH and GOROOT": ``` export PATH="$GOROOT/bin:$PATH" export PATH="$PATH:$GOPATH/bin" ``` This effectively overrides the first line as `$GOROOT/bin` is also expected to contain a `go` binary. However that binary is not controlled by `goenv`. Furthermore AFAICT these two lines do not make "goenv manage GOPATH and GOROOT". This has confused at least [one other user](#186 (comment)). This change removes the section about GOROOT and GOPATH as I don't see why it would belong in the goenv installation instructions.
fix: missing exclusion of rehash on init (#437) Cut time by 75% ~ via 🐹 v1.23.4 via 🐍 v3.12.8 (main) on ☁️ ➜ time eval "$(goenv init -)" real 0m0.755s user 0m0.138s sys 0m0.207s ~ via 🐹 v1.23.4 via 🐍 v3.12.8 (main) on ☁️ ➜ time eval "$(goenv init - --no-rehash)" real 0m0.407s user 0m0.099s sys 0m0.140s After fix: ~ via 🐹 v1.23.4 via 🐍 v3.12.8 (main) on ☁️ ➜ time eval "$(goenv init - --no-rehash)" real 0m0.133s user 0m0.032s sys 0m0.051s Signed-off-by: Justin Lecher <justin.lecher@astrazeneca.com>
PreviousNext