+
Skip to content

Fixed Repo.move() and added test #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 19, 2016
Merged

Fixed Repo.move() and added test #330

merged 15 commits into from
May 19, 2016

Conversation

minkezhang
Copy link
Contributor

@minkezhang minkezhang commented May 14, 2016

Repo.move() previously was broken and did not work as intended; this is a fix for this issue.

  • Deleted private function Repo._updateTree()
  • Updated Repo.commit() docs: as per https://developer.github.com/v3/git/commits/#create-a-commit, arg tree is a SHA string previously created (via Repo.createTree()), not the tree object itself.
  • Changed Repo.updateHead() API: added force arg to match Github API docs (https://developer.github.com/v3/git/refs/#update-a-reference).
  • Removed internal reference to deprecated Repo.updateTree(): previously referenced in Repo.move(); this has been addressed.
  • Added Repo.move() test: assert moved file has same contents, assert old path does not exist after update.

@minkezhang
Copy link
Contributor Author

Should squash the commits when merging.

@clayreimann
Copy link
Member

Thanks @cripplet. I'll get this out today or tomorrow.

Note to me: this is a breaking change.

@clayreimann clayreimann added this to the 2.0 milestone May 17, 2016
@clayreimann clayreimann merged commit c50436a into github-tools:master May 19, 2016
@clayreimann
Copy link
Member

@cripplet This is released in v2.0 which is building now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载