Add repo.collaborators #304
Conversation
|
Hi. This method you've implemented follows (pretty much) an anti-pattern called Boolean trap. Based on a given Boolean value, the method changes its behavior. The behavior should be split in two methods, each with its own semantic. For example: repo.collaborators()
repo.isCollaborator() |
| // ------- | ||
|
|
||
| this.collaborators = function (username, cb) { | ||
| var command = repoPath + '/collaborators' + (username ? '/' + username : '') |
There was a problem hiding this comment.
Once you split the method in two there will be no need for this variable. You can use the string directly into the method call.
|
Thanks for the clarification @AurelioDeRosa - I was attempting to be consistent with the other methods in the library (ie. |
|
The tests were broken so I had to fix them. Apart from that, everything was good and the PR has been merged. |
Added the ability to get a list of collaborators and check if a user is a collaborator per documentation. Note that for the life of me I can't get the tests to pass, even though the code works fine and the tests look like all the others. Figured I'd ask here before diving even further trying to debug the tests.