-
Notifications
You must be signed in to change notification settings - Fork 778
Use babel umd #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use babel umd #290
Conversation
@clayreimann the reason why we didn't use Babel anymore is because we'll lose most of the code coverage tooling. While it's definitely possible to have the final metric value (e.g. 85% covered), the covered/uncovered lines will be lost. Also, altought very painful, we still need the dist files as demonstrated by issues like #285. |
c80d738
to
5668969
Compare
* Will work the same as the current UMD wrapper after Babel 6.6.0
5668969
to
1af7e04
Compare
0b2a573
to
41782f3
Compare
I have:
If this all looks good I'll add one more commit that fixes indentation in I think the changes here are going to be critical in allowing us to modularize our codebase going forward. |
This is a huge amount of work, @clayreimann — thank you very much for it. I've admittedly been a bit distant from how @AurelioDeRosa has been managing the code the last while so it's ultimately up to him, but having gone through most of the PR (albeit fairly quickly), it looks pretty terrific.
That's all for now, will add more if I see anything else. |
coverage/ | ||
|
||
.zuulrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this file for?
A couple more comments:
|
I'd also say that we probably should start creating a v.1 branch. This way we can start merging all this work plus other things that will come in that branch, but keep merging the PRs other devs are submitting. Once we complete version 1, we can rebase and complete a massive merge. |
This should not be merged until Babel6.6.0
is released.babel@6.6.x
is released.This could constitute the beginnings of the rework for the
0.12.x
/1.0.0
releaseTo Do:
Add browser tests with zuulWill be fixed by Add cross-browser tests #300Add deploy scripts that generate theWill be fixed by Automatic dist generation #299dist/
artifactsAdd auto-generated documentationWill be fixed by Rewrite inline comments to make use of jsDoc #239