+
Skip to content

Add options for getting list pull requests #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add options for getting list pull requests #250

wants to merge 5 commits into from

Conversation

sairoutine
Copy link
Contributor

I want to get list of pull requests with options of sort, direction and so on.
But currently, I can specify only state option.
So I've added specifying some options to getting list pull requests.

https://developer.github.com/v3/pulls/#list-pull-requests

@sairoutine
Copy link
Contributor Author

I expect that #249 commit causes repo.getSha failed to pass test.

@aendra-rininsland
Copy link
Member

@sairoutine c3d5bb6 doesn't touch anything testing or code-related. It's likely your commit broke something.

Regardless, you'll need to add unit tests before I can merge this. We're hoping to merge #248 in the next day or two; if you could rebase against that and write your tests in Chai, that'd be great.

Thanks!

@sairoutine
Copy link
Contributor Author

All right.
I’m looking forward to your merging #248 !

Thanks.

@aendra-rininsland
Copy link
Member

@sairoutine Hi! I've merged #248! 🎉

@sairoutine
Copy link
Contributor Author

I had written the test code, and succeeded to pass the test in my local PC.
But, on Travis CI, my code did not pass the test.
I want some helps.

Thanks.

@aendra-rininsland
Copy link
Member

Hi @sairoutine!

I just checked out your PR and ran the tests, worked fine for me. Travis might just be acting 💩 right now.

Thanks for your contribution! 🎉 👍 :shipit:

Closed via 3eff47e.

@sairoutine sairoutine deleted the fix_listpulls branch November 21, 2015 08:29
@AurelioDeRosa AurelioDeRosa modified the milestones: 0.12.0, 0.11.0 Jan 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载