Allow repo.listBranches to support branch names that contains slashes #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #31. |
|
Hmm, tests failed in Node 0.11 but not 0.10. I'd love to add this to 0.10.7, will take a look at fixing your tests. |
aendra-rininsland
pushed a commit
that referenced
this pull request
Oct 17, 2015
Allow repo.listBranches to support branch names that contains slashes
|
Phh, what the heck? Now tests pass fine. MERGING. 👍 Many thanks, @olivierbeaulieu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an issue with
listBranches- we use slashes in our branch naming convention.For example, the branch
feature/my-cool-featurewould return onlymy-cool-feature. This fixes this issue.