+
Skip to content

expose xhr #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

expose xhr #186

wants to merge 1 commit into from

Conversation

sielay
Copy link
Contributor

@sielay sielay commented May 25, 2015

Small change to expose XHR, so we can use conditional requests and save some quota ;)

@aendra-rininsland
Copy link
Member

@sielay Excellent, would you mind writing a quite test suite for this? Would love to add this to 0.10.7 if possible! Apologies for the delay getting back to you!

@aendra-rininsland
Copy link
Member

I fixed the conflicts and merged this in 2ac1fb9. I don't think it needs unit tests, it's just adding a callback argument. Thanks a bajillion @sielay — you've made working on #45 much easier! 😄

@sielay
Copy link
Contributor Author

sielay commented Nov 10, 2015

@Aendrew thanks, forgot about this one already ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载