-
Notifications
You must be signed in to change notification settings - Fork 778
Add events API to issues #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The first bit is taken care of in #161, so please remove that. Please also add documentation and unit tests, rebasing once done. Thanks! |
As far as I can tell, #161 is for contributors (people who have written On Wed, 29 Apr 2015 17:15 Ændrew Rininsland notifications@github.com
|
As far as testing, there are no tests for issues yet, and |
Closed in error; reopening. |
e746e5d
to
6f04f13
Compare
Hi @raphink. Are you still interested in updating this PR? |
@AurelioDeRosa sure. What changes are still required? |
// -------- | ||
|
||
this.listCollaborators = function(cb) { | ||
_request('GET', repoPath + "/collaborators", null, function(err, collabs) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be changed in:
_request('GET', repoPath + "/collaborators", null, cb);
This PR needs tests and also to add documentation to the README file. Thank you for the interest. |
@AurelioDeRosa Any comment on #180 (comment) ? Has the situation changed regarding testing since? |
We have tests for issues now. You can find them in the |
OK I'll have a look. |
@AurelioDeRosa I have rebased and added tests |
@AurelioDeRosa @clayreimann any news from this? |
It's not merged yet (obviously) and two of the three APIs you're adding have been added already, but I'll get issue events in today or tomorrow. |
Is collaborators added? |
I believe so. We have both contributors and collaborators |
@raphink you can see the docs for contributors and collaborators |
Thanks. I'll have to rebase my code. |
@raphink This is released with version |
Thank you. |
No description provided.