+
Skip to content

Add events API to issues #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Add events API to issues #180

wants to merge 6 commits into from

Conversation

raphink
Copy link
Contributor

@raphink raphink commented Apr 29, 2015

No description provided.

@aendra-rininsland
Copy link
Member

The first bit is taken care of in #161, so please remove that. Please also add documentation and unit tests, rebasing once done. Thanks!

@raphink
Copy link
Contributor Author

raphink commented Apr 29, 2015

As far as I can tell, #161 is for contributors (people who have written
code merged in the project), but my commit adds support for collaborators
(people with commit/admin rights on the project), which is different.

On Wed, 29 Apr 2015 17:15 Ændrew Rininsland notifications@github.com
wrote:

The first bit is taken care of in #161
#161, so please remove that.
Please also add documentation and unit tests. Thanks!


Reply to this email directly or view it on GitHub
#180 (comment).

@raphink
Copy link
Contributor Author

raphink commented Apr 30, 2015

As far as testing, there are no tests for issues yet, and listCollaborators requires a user with priviledges on the repository, which is not the case of the test user (thankfully), so it'll always return a 403.

@aendra-rininsland
Copy link
Member

Closed in error; reopening.

@aendra-rininsland aendra-rininsland force-pushed the master branch 2 times, most recently from e746e5d to 6f04f13 Compare November 17, 2015 16:15
@AurelioDeRosa
Copy link
Member

Hi @raphink. Are you still interested in updating this PR?

@raphink
Copy link
Contributor Author

raphink commented Jan 24, 2016

@AurelioDeRosa sure. What changes are still required?

// --------

this.listCollaborators = function(cb) {
_request('GET', repoPath + "/collaborators", null, function(err, collabs) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be changed in:

_request('GET', repoPath + "/collaborators", null, cb);

@AurelioDeRosa
Copy link
Member

This PR needs tests and also to add documentation to the README file. Thank you for the interest.

@raphink
Copy link
Contributor Author

raphink commented Jan 24, 2016

@AurelioDeRosa Any comment on #180 (comment) ? Has the situation changed regarding testing since?

@AurelioDeRosa
Copy link
Member

We have tests for issues now. You can find them in the test folder.

@raphink
Copy link
Contributor Author

raphink commented Feb 20, 2016

OK I'll have a look.

@raphink
Copy link
Contributor Author

raphink commented Feb 24, 2016

@AurelioDeRosa I have rebased and added tests

@clayreimann clayreimann added this to the 1.x milestone Apr 27, 2016
@raphink
Copy link
Contributor Author

raphink commented May 4, 2016

@AurelioDeRosa @clayreimann any news from this?

@clayreimann
Copy link
Member

It's not merged yet (obviously) and two of the three APIs you're adding have been added already, but I'll get issue events in today or tomorrow.

@raphink
Copy link
Contributor Author

raphink commented May 4, 2016

Is collaborators added?

@clayreimann
Copy link
Member

I believe so. We have both contributors and collaborators

@clayreimann
Copy link
Member

@raphink you can see the docs for contributors and collaborators

@raphink
Copy link
Contributor Author

raphink commented May 4, 2016

Thanks. I'll have to rebase my code.

@clayreimann
Copy link
Member

@raphink This is released with version 2.2.0

@raphink
Copy link
Contributor Author

raphink commented May 29, 2016

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载