Use only one time parameter when quering multiple pages #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like a plan. I'm not sure two regex replaces are the best or most performant option, though; also, it's a really old PR and I'd like some unit tests to ensure it doesn't break anything else. Mind doing so? Thanks! |
|
Closed in error; reopening. |
e746e5d to
6f04f13
Compare
AurelioDeRosa
added a commit
that referenced
this pull request
Nov 22, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a resource has multiple pages the script will use
nextvalue to retrieve next page.Because all requests are done with datetime append to url (probably to avoid caching)
nextcontaines that link.https://api.github.com/repos/user/repo/issues/events?per_page=100&1409248439577Second page will be requested by appending a new datetime, so we'll have something like
https://api.github.com/repos/user/repo/issues/events?per_page=100&page=2&1409248439577=&1409257105342Third page url will contain 3 datetime stamps and so on. At some point this will rise an error as browser (and server) has a limit for url size. This way it will cut some of the parameters or will simply throw an error.