+
Skip to content

Bad use of the send() method of XMLHttpRequest  #195

Closed
@firehist

Description

@firehist

According to the XMLHttpRequest whatwg.org specification:
If the request method is GET or HEAD, set body to null.

When use _request method, data was not send to the GitHup API:
https://github.com/michael/github/blob/master/github.js#L525
https://github.com/michael/github/blob/master/github.js#L599

It works well on master branch 'cause GitHub API set ref to master by default.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载