contrib/persistent-https: update ldflags syntax for Go 1.7+ #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes contrib/persistent-https builds for Go v1.7+ and is compatible with Go v1.5+.
Running `make all` in `contrib/persistent-https` results in a failure on Go 1.7 and above.
Specifically, the error is:
go build -o git-remote-persistent-https \
-ldflags "-X main._BUILD_EMBED_LABEL 1468613136"
# _/Users/parkr/github/git/contrib/persistent-https
/usr/local/Cellar/go/1.7rc1/libexec/pkg/tool/darwin_amd64/link: -X flag requires argument of the form importpath.name=value
make: *** [git-remote-persistent-https] Error 2
This `name=value` syntax for the -X flag was introduced in Go v1.5 (released Aug 19, 2015):
- release notes: https://golang.org/doc/go1.5#link
- commit: golang/go@12795c0
In Go v1.7, support for the old syntax was removed:
- release notes: https://tip.golang.org/doc/go1.7#compiler
- commit: golang/go@51b624e
This patch includes the `=` to fix builds with Go v1.7+.
|
/cc #270 which was to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes contrib/persistent-https builds for Go v1.7+ and is compatible with Go v1.5+.
Running
make allincontrib/persistent-httpsresults in a failure on Go 1.7 and above.Specifically, the error is:
This
name=valuesyntax for the -X flag was introduced in Go v1.5 (released Aug 19, 2015):In Go v1.7, support for the old syntax was removed:
This patch includes the
=to fix builds with Go v1.7+.