Support transfer none return strings in callbacks #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adb0cc8 to
3f0f130
Compare
This introduces a new public class "ConstantString". This class can be used to keep a pointer to a string alive as long as the instance is alive. In case of callbacks a returned string with transfer none should live forever. A user can create an instance of "ConstantString" and keep the instance around forever to keep the pointer alive forever. This puts the burden of managing string memory which lives forever on the user side. If the string would simply allocated by gir.core and never be freed there could be huge memory leaks if strings are allocated again and again and they would never be freed.
3f0f130 to
54e93a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is working as this only applies to callback return values of type string. As the ownership is not transferred this implies that the string should never be freed as it is generated by the callback.