+
Skip to content

Fix generic gobject types #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2023
Merged

Fix generic gobject types #910

merged 1 commit into from
Jul 28, 2023

Conversation

hol430
Copy link
Contributor

@hol430 hol430 commented Jul 27, 2023

  • I agree that my contribution may be licensed either under MIT or any version of LGPL license.

Fixes #909

badcel
badcel requested changes Jul 27, 2023
View reviewed changes
Copy link
Member

@badcel badcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Good catch that generics are not working. Please see my comments and fix the code format using dotnet format GirCore.sln in src folder.

@hol430 hol430 force-pushed the bug/GenericGObject branch from e924de7 to 7303335 Compare July 28, 2023 05:00
@hol430 hol430 force-pushed the bug/GenericGObject branch from 7303335 to efd0756 Compare July 28, 2023 05:16
@badcel badcel merged commit 38761d5 into gircore:main Jul 28, 2023
@badcel
Copy link
Member

badcel commented Jul 28, 2023

Thanks for your contribution 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@badcel badcel badcel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot define a generic gobject type

2 participants

@hol430 @badcel
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载