Sync'ed dependencies in csproj/gir/Module.cs #875
Conversation
There was a problem hiding this comment.
Thank you! Very good work. There was some overhaul pretty necessary. Especially in Gtk.Module there was a lot of stuff which did not belong there.
In general I opted to remove explicit references to GObject if possible (in those cases it is referenced implicitly). Otherwise every module would need to reference GObject explicitly. I think this keeps the dependencies more in line with the gir files. Please see my comments.
Regarding freetype please remove it's GLib dependency. As it does not define a "shared-library" in the namespace tag, please don't add a Module.cs. There would be the code to sett the DLL-Library name, which is not possible due to the missing "shared-library" attribute.
|
I applied all changes, as requested. |
There was a problem hiding this comment.
Thanks for updating your pr.
I think you missed my comment in regard to: src/Libs/GstPbutils-1.0/Public/Module.cs: GstPbUtils should not reference GObject directly and should not initialize it in the Module.cs.
Additionally I would like you to squash your commits into one and update the commit message of your first commit to match the current state. It should get a bit shorter after your last changes. Your second commit message should be obsolete then.
If those points are addressed I think it is good to go 🚀
There are still some discrepancies between gir and csproj files, documented below. This changeset also normalize the format of csproj files moving metadata to the top and dependencies to the bottom. freetype2-2.0 - gir does not include GObject - gir does not include GLib - Module.cs is missing GdkPixbuf-2.0 - gir includes GModule (that cannot be included by csproj) Gst-1.0 - gir includes GModule (that cannot be included by csproj) GstAudio-1.0 - gir includes GModule (that cannot be included by csproj) GstBase-1.0 - gir includes GModule (that cannot be included by csproj)
There are still some discrepancies between gir and csproj files, documented below. This changeset also normalize the format of csproj files moving metadata to the top and dependencies to the bottom.
Adw-1
cairo-1.0
freetype2-2.0
Gdk-4.0
GdkPixbuf-2.0
Gst-1.0
GstAudio-1.0
GstBase-1.0
GstPbutils-1.0
GstVideo-1.0
I agree that my contribution may be licensed either under MIT or any version of LGPL license.