-
Notifications
You must be signed in to change notification settings - Fork 37
gtksourceview bindings #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b40809d
to
a56980f
Compare
@badcel - this seems to be basically working now. I've had to add support for rendering interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this is fine. Just some minor remarks regarding the sample and solution file.
acc7631
to
de65e32
Compare
All good suggestions. I think I've implemented them all, though I'm unsure if I've setup the .sln file correctly, as my IDE doesn't support editing them visually, and the CLI in this area seems somewhat ambiguous. |
Yep, you have nailed it, even if done with the CLI 👍: The folder structure looks perfectly fine in Rider. All the other points are fixed, too. If you do a final rebase this is good to go: 🚀 |
Thank you 🚀 |
Eventually fixes #789