+
Skip to content

gtksourceview bindings #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2023
Merged

gtksourceview bindings #790

merged 1 commit into from
Apr 29, 2023

Conversation

hol430
Copy link
Contributor

@hol430 hol430 commented Feb 5, 2023

Eventually fixes #789

@hol430 hol430 marked this pull request as draft February 5, 2023 10:21
@hol430 hol430 force-pushed the gtksourceview branch 2 times, most recently from b40809d to a56980f Compare April 24, 2023 00:01
@hol430
Copy link
Contributor Author

hol430 commented Apr 24, 2023

@badcel - this seems to be basically working now. I've had to add support for rendering interface GPtrArray return types in the internal layer, but I can move this into a separate branch/PR if you prefer. Otherwise let me know if you spot anything else suspicious here.

@hol430 hol430 marked this pull request as ready for review April 24, 2023 00:14
Copy link
Member

@badcel badcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this is fine. Just some minor remarks regarding the sample and solution file.

@hol430 hol430 force-pushed the gtksourceview branch 2 times, most recently from acc7631 to de65e32 Compare April 27, 2023 02:15
@hol430
Copy link
Contributor Author

hol430 commented Apr 27, 2023

All good suggestions. I think I've implemented them all, though I'm unsure if I've setup the .sln file correctly, as my IDE doesn't support editing them visually, and the CLI in this area seems somewhat ambiguous.

@badcel
Copy link
Member

badcel commented Apr 27, 2023

Yep, you have nailed it, even if done with the CLI 👍: The folder structure looks perfectly fine in Rider.

All the other points are fixed, too. If you do a final rebase this is good to go: 🚀

@badcel badcel merged commit a4bd561 into gircore:main Apr 29, 2023
@badcel
Copy link
Member

badcel commented Apr 29, 2023

Thank you 🚀

@hol430 hol430 deleted the gtksourceview branch May 1, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bind GtkSourceView
2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载