Handle `RejectedExecutionException` everywhere #4747

lcian · 2025-09-23T09:37:31Z

📜 Description

Handle RejectedExecutionException on submit where it was previously unhandled
Log the failure with WARNING level everywhere
Change the signature of methods in SentryExecutorService to throws RejectedExecutionException (not sure if this is effective because it's a RuntimeException anyway)
- An alternative would be to handle the exception e.g. in the submit method itself of SentryExecutorService, but then we wouldn't throw it to the caller which can log a more specific message
Change deviceInfoUtil to be nullable in DefaultAndroidEventProcessor. Upon accessing it, if it's null it will still trigger an NPE and log things like options.getLogger().log(SentryLevel.ERROR, "Failed to retrieve device info", e);
- Perhaps here it's better to check for null instead of relying on the NPE to avoid the performance hit of the exception throwing and handling flow, to the expense of some DRYness
  -> ended up changing it as described (with null checks)

💡 Motivation and Context

Closes: #4660
Closes: JAVA-144

💚 How did you test it?

All tests pass

📝 Checklist

I added GH Issue ID & Linear ID
I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

linear · 2025-09-23T09:37:34Z

JAVA-144 `RejectedExecutionException` sometimes is not handled for `ISentryExecutorService.submit`

github-actions · 2025-09-23T09:37:51Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/QueuedThreadPoolExecutor.java

github-actions · 2025-09-23T09:46:58Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	327.15 ms	389.48 ms	62.33 ms
Size	1.58 MiB	2.10 MiB	533.40 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`c8125f3`	397.65 ms	485.14 ms	87.49 ms
`ee747ae`	386.94 ms	431.43 ms	44.49 ms
`23d6b12`	354.10 ms	408.38 ms	54.28 ms
`d217708`	409.83 ms	474.72 ms	64.89 ms
`d217708`	411.22 ms	430.86 ms	19.63 ms
`ee747ae`	400.46 ms	423.61 ms	23.15 ms
`17a0955`	372.53 ms	446.70 ms	74.17 ms
`3d205d0`	352.15 ms	432.53 ms	80.38 ms
`1df7eb6`	397.04 ms	429.64 ms	32.60 ms
`b750b96`	408.98 ms	480.32 ms	71.34 ms

App size

Revision	Plain	With Sentry	Diff
`c8125f3`	1.58 MiB	2.10 MiB	532.32 KiB
`ee747ae`	1.58 MiB	2.10 MiB	530.95 KiB
`23d6b12`	1.58 MiB	2.10 MiB	532.31 KiB
`d217708`	1.58 MiB	2.10 MiB	532.97 KiB
`d217708`	1.58 MiB	2.10 MiB	532.97 KiB
`ee747ae`	1.58 MiB	2.10 MiB	530.95 KiB
`17a0955`	1.58 MiB	2.10 MiB	533.20 KiB
`3d205d0`	1.58 MiB	2.10 MiB	532.97 KiB
`1df7eb6`	1.58 MiB	2.10 MiB	532.97 KiB
`b750b96`	1.58 MiB	2.10 MiB	533.19 KiB

Previous results on branch: lcian/handle-rejected-execution-exception

Startup times

Revision	Plain	With Sentry	Diff
`922c01f`	374.10 ms	411.06 ms	36.96 ms
`b8c9ebc`	395.56 ms	451.02 ms	55.46 ms

App size

Revision	Plain	With Sentry	Diff
`922c01f`	1.58 MiB	2.10 MiB	533.33 KiB
`b8c9ebc`	1.58 MiB	2.10 MiB	533.37 KiB

github-actions · 2025-09-23T10:29:31Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/QueuedThreadPoolExecutor.java

markushi

LGTM

sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java

github-actions · 2025-09-25T08:12:54Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/QueuedThreadPoolExecutor.java

adinauer

Thanks for taking care of this!

sentry/src/main/java/io/sentry/SentryExecutorService.java

github-actions · 2025-09-25T12:15:02Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/QueuedThreadPoolExecutor.java

github-actions · 2025-09-25T12:18:56Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/QueuedThreadPoolExecutor.java

github-actions · 2025-09-26T07:38:31Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/QueuedThreadPoolExecutor.java

github-actions · 2025-09-26T07:54:48Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/QueuedThreadPoolExecutor.java

lcian added 7 commits September 23, 2025 10:13

wip

bb57a10

wip

47cf358

improve

0a0f99a

improve

514bc23

improve

fefa604

improve

ff7e952

improve

78abc13

lcian requested review from adinauer, romtsn, stefanosiano and markushi as code owners September 23, 2025 09:37

This comment was marked as outdated.

Sign in to view

improve

ba456cb

This comment was marked as outdated.

Sign in to view

markushi approved these changes Sep 23, 2025

View reviewed changes

sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java Show resolved Hide resolved

handle null everywhere

a3ab661

Format code

9cf5463

This comment was marked as outdated.

Sign in to view

adinauer approved these changes Sep 25, 2025

View reviewed changes

sentry/src/main/java/io/sentry/SentryExecutorService.java Show resolved Hide resolved

trigger CI

63f225e

changelog

520353f

lcian enabled auto-merge (squash) September 25, 2025 12:18

This comment was marked as outdated.

Sign in to view

lcian disabled auto-merge September 25, 2025 12:31

Merge branch 'main' into lcian/handle-rejected-execution-exception

97404fc

reset hasScheduled for logs batch processor

053342d

lcian enabled auto-merge (squash) September 26, 2025 08:05

lcian merged commit 818a27d into main Sep 26, 2025
45 checks passed

lcian deleted the lcian/handle-rejected-execution-exception branch September 26, 2025 08:22

Uh oh!

Handle RejectedExecutionException everywhere #4747

Handle RejectedExecutionException everywhere #4747

Uh oh!

Conversation

lcian commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

linear bot commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 23, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: lcian/handle-rejected-execution-exception

Startup times

App size

Uh oh!

github-actions bot commented Sep 23, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

This comment was marked as outdated.

Uh oh!

markushi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Sep 25, 2025 • edited by lcian Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 Detected changes in high risk code 🚨

Uh oh!

This comment was marked as outdated.

Uh oh!

adinauer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Sep 25, 2025 • edited by lcian Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Sep 25, 2025 • edited by lcian Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 Detected changes in high risk code 🚨

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Sep 26, 2025 • edited by lcian Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Sep 26, 2025 • edited by lcian Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 Detected changes in high risk code 🚨

Uh oh!

Uh oh!

Uh oh!

Handle `RejectedExecutionException` everywhere #4747

Handle `RejectedExecutionException` everywhere #4747

lcian commented Sep 23, 2025 •

edited

Loading

github-actions bot commented Sep 23, 2025 •

edited

Loading

github-actions bot commented Sep 25, 2025 •

edited by lcian

Loading

github-actions bot commented Sep 25, 2025 •

edited by lcian

Loading

github-actions bot commented Sep 25, 2025 •

edited by lcian

Loading

github-actions bot commented Sep 26, 2025 •

edited by lcian

Loading

github-actions bot commented Sep 26, 2025 •

edited by lcian

Loading