+
Skip to content

Make the additional env vars more robust #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 17, 2022

Conversation

kienstra
Copy link
Member

@kienstra kienstra commented Oct 16, 2022

Changes

  • Before, this was only after a checkout step
  • But there isn't always a checkout step, and it still might need these env vars

As it is now,
it depends on a checkout step.
But there can be a custom checkout step,
or a restore_workspace.

command = `echo '${exportVars}' >> $BASH_ENV`;
} catch (error) {
command = `There was an error setting the variables: ${
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Add an echo statement

@kienstra kienstra merged commit 6a557b2 into develop Oct 17, 2022
@kienstra kienstra deleted the fix/checkout-additional-steps branch October 17, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载