+
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
89 commits
Select commit Hold shift + click to select a range
5c98271
Move some Bash scripts to src/scripts/ and run shellcheck for them
kienstra Aug 28, 2022
fbffa9c
Fix the shellcheck errors in get_picard_container()
kienstra Aug 28, 2022
9ebb13a
Strip the #from the scripts
kienstra Aug 28, 2022
ed55f48
Add the index.ts file I forgot to stage
kienstra Aug 28, 2022
f52c1f0
Fix shellcheck errors in addEnvVars
kienstra Aug 28, 2022
2e88997
Split the bash for docker exec into a script
kienstra Aug 28, 2022
a5476bc
See if changing content to any helps
kienstra Aug 28, 2022
6324808
Attempt to get tests to pass with importing envVars.sh
kienstra Aug 28, 2022
f81bc59
Revert changes to package.json and package-lock.json
kienstra Aug 28, 2022
d5041c6
Add a baseUrl to tsconfig.json and update import statements
kienstra Aug 28, 2022
d4f28d4
Fix imports in classes and util functions
kienstra Aug 29, 2022
c28930b
Fix linting errors
kienstra Aug 29, 2022
4a39ec8
Move subdirecdtories of src/utils/ into src/
kienstra Aug 29, 2022
c65d5ef
Switch to Jest for testing, move a single test to src/cache/test/
kienstra Aug 29, 2022
d8af63a
Remove @vscode/test-electron
kienstra Aug 29, 2022
8083a36
Attempt at Inversify, thought it's not working
kienstra Aug 29, 2022
c739304
Use inversify for dependency injection, which is working right now
kienstra Sep 5, 2022
e2c9fb1
Add shellcheck for linting .sh files
kienstra Sep 5, 2022
ed363bd
Move test for getFinalTerminalName() into terminal/test
kienstra Sep 5, 2022
fe4c2c2
Merge in develop, resolve conflicts
kienstra Sep 5, 2022
a657bf3
Fix linting errors by removing any types
kienstra Sep 6, 2022
5f978f5
Make npm test pass by fixing the return types
kienstra Sep 6, 2022
2d0d0f9
Make tests pass again
kienstra Sep 6, 2022
4674bb6
Stage EnvPath, which I forgot to stage
kienstra Sep 6, 2022
348c8f6
mv types.ts to Types.ts
kienstra Sep 6, 2022
29ee77c
Add a test for the isMac() method, though should probably go in a fil…
kienstra Sep 6, 2022
878d7ba
Move getLogFilePath.spec.ts to log/test/
kienstra Sep 6, 2022
c84e0c5
Move getDebuggingTerminalName.test.ts to terminal/
kienstra Sep 7, 2022
36707af
Move getTerminalName.test.ts to terminal/
kienstra Sep 7, 2022
7734d20
Move getFinalTerminalName.test.ts to terminal/
kienstra Sep 7, 2022
161b46a
Add sanitizeLicenseKey test to license/
kienstra Sep 7, 2022
c8d637b
Move the test for areTerminalsClosed to terminals/test/
kienstra Sep 7, 2022
00fdd19
Move isTrialExpired() test to license/test/
kienstra Sep 7, 2022
9f19713
Make the moved JobProvider test pass
kienstra Sep 8, 2022
219db82
Add a type for the container
kienstra Sep 8, 2022
f4353a2
Use decorator syntax instead of functions
kienstra Sep 9, 2022
d3dfe91
Move more tests into their correct files
kienstra Sep 9, 2022
9b519de
Add to tsconfig.json experimentalDecorators: true
kienstra Sep 9, 2022
d38d03b
Convert more functions to classes to use dependency injection
kienstra Sep 9, 2022
1899dec
Create an AllJobs file to get all jobs
kienstra Sep 9, 2022
a6b40d5
Copy more tests to EnvPath.spec.ts
kienstra Sep 9, 2022
55eaa38
Modify tests in Workspace
kienstra Sep 9, 2022
6b6fc6c
Move the tests for the Email class into Email.spec.ts
kienstra Sep 9, 2022
8aca8bd
Remove an extra line in the EnvPath test
kienstra Sep 9, 2022
fb9d8e5
Run jest on all test files
kienstra Sep 10, 2022
5a2227e
Remove binding to singleton scope
kienstra Sep 10, 2022
94d23c9
Convert setBuildAgentSettings to a class
kienstra Sep 10, 2022
c99c0ff
Move more test files into their test/ directories
kienstra Sep 10, 2022
3a5495f
Stage files I forgot to stage
kienstra Sep 10, 2022
e094440
Merge branch 'develop' into add/shellcheck-and-dependency-injection
kienstra Sep 10, 2022
15ec172
Begin moving the registration of commands to a Registrar class
kienstra Sep 10, 2022
f0f6893
Move the *Ioc files to common/
kienstra Sep 11, 2022
cb76d82
Fix failing unit tests by fixing the types
kienstra Sep 11, 2022
c8988ac
Fix the failed test from EditorGateway
kienstra Sep 11, 2022
38ce08b
Move webview back to src/
kienstra Sep 11, 2022
97c9fbe
Change the JobProviderFactory to a normal class
kienstra Sep 11, 2022
079c174
Change the JobProviderFactory to a normal class
kienstra Sep 11, 2022
205c5f7
Use the factory correctly in extension.ts
kienstra Sep 11, 2022
f3a2183
Use the factory correctly in extension.ts
kienstra Sep 11, 2022
67e3488
Create a command for help, and a unit test for it
kienstra Sep 11, 2022
152e0cd
Move the command to select all jobs to command/
kienstra Sep 11, 2022
75ed8c3
Fix some linting errors
kienstra Sep 11, 2022
7c95b98
Create a factory for Registrar
kienstra Sep 11, 2022
8e64d9f
Move showLogFile into a class
kienstra Sep 12, 2022
9dcbd6b
Add handlers to Registrar
kienstra Sep 12, 2022
8a8d2d0
Create a main extension file to activate and deactivate
kienstra Sep 12, 2022
063e652
Add more comamnds to Registrar
kienstra Sep 12, 2022
3c1e352
Change the description of the LocalCi test
kienstra Sep 12, 2022
1d6506f
Move the gateways to a gateway/ directory
kienstra Sep 12, 2022
a7add97
Remove webview from src/
kienstra Sep 12, 2022
f51e2ec
Move commands/ to command/
kienstra Sep 12, 2022
c740486
Move scripts/ to script/
kienstra Sep 12, 2022
f2df33b
Fix the bash syntax that didn't get the container
kienstra Sep 12, 2022
0e1f9c0
Strip the shellcheck command
kienstra Sep 12, 2022
eedb7f1
Change vscode import to a type import when that's possible
kienstra Sep 12, 2022
ee8d7a9
Remove sinon from the repo
kienstra Sep 12, 2022
8260d09
Alphabetize the dependencies in import statements
kienstra Sep 14, 2022
af73bf5
Use the helper test function
kienstra Sep 14, 2022
fa62294
Convert applyPipelineParameters() to a class
kienstra Sep 17, 2022
ea4d074
Move logic to clean up images to script so this can lint it
kienstra Sep 17, 2022
2ce7ea7
Move the Bash syntax to commit the container into a script
kienstra Sep 17, 2022
4a292a2
Remove duplicate test
kienstra Sep 17, 2022
5b4f71a
Use Object.entries() instead of Object.keys()
kienstra Sep 17, 2022
83719cd
Fix linting errors in LoggingProcessGateway
kienstra Sep 18, 2022
d33a31f
Will revert: inject the logging gateway
kienstra Sep 18, 2022
c5179fa
Remove the conditional for assigning imageIdToExclude
kienstra Sep 18, 2022
942a845
Stop using the LoggingChildProcessGateway
kienstra Sep 18, 2022
c0bf6ba
Bump the Node version in the test job
kienstra Sep 18, 2022
8944aac
Remove the last digit in the docker image tag
kienstra Sep 18, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@ orbs:
jobs:
test:
docker:
- image: cimg/node:16.8.0-browsers
- image: cimg/node:16.17
steps:
- checkout
- node/install-packages
- run: npm test
- run: npm run lint
resource_class: large
package:
docker:
Expand Down
3 changes: 1 addition & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@ out
dist
bin
node_modules
.vscode-test/
*.vsix
.DS_Store
.DS_Store
16 changes: 5 additions & 11 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,14 @@
"outFiles": [
"${workspaceFolder}/dist/**/*.js"
],
"preLaunchTask": "${defaultBuildTask}"
"preLaunchTask": "npm: watch"
},
{
"name": "Extension Tests",
"type": "extensionHost",
"name": "Unit Tests",
"type": "node",
"request": "launch",
"args": [
"--extensionDevelopmentPath=${workspaceFolder}",
"--extensionTestsPath=${workspaceFolder}/out/test/suite/index"
],
"outFiles": [
"${workspaceFolder}/out/test/**/*.js"
],
"preLaunchTask": "npm: test-watch"
"program": "${workspaceFolder}/node_modules/.bin/jest",
"console": "integratedTerminal"
}
]
}
1 change: 0 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// Place your settings in this file to overwrite default and user settings.
{
"files.exclude": {
"out": false, // set this to true to hide the "out" folder with the compiled JS files
Expand Down
10 changes: 0 additions & 10 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,6 @@
"kind": "build",
"isDefault": true
}
},
{
"type": "npm",
"script": "test-watch",
"problemMatcher": "$tsc-watch",
"isBackground": true,
"presentation": {
"reveal": "never"
},
"group": "build"
}
]
}
6 changes: 3 additions & 3 deletions .vscodeignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.vscode/**
.vscode-test/**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was where the compiled test files were before.

But now, we don't have to compile the TypeScript before running unit tests.

We'll just run jest.

.circleci/**
.husky/**
artifacts/**
Expand All @@ -9,7 +8,8 @@ src/**
CONTRIBUTING.md
.gitignore
.nvmrc
**/tsconfig.json
**/.eslintrc.json
tsconfig.json
.eslintrc.json
jest.config.js
**/*.map
**/*.ts
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
<img src="https://user-images.githubusercontent.com/4063887/138581226-9aeb09aa-e9c4-44e3-8b22-a6022080119b.gif" alt="restarting the editor">
</p>

9. If step 3 causes the warning "The task 'npm: watch' cannot be tracked," you can either activate the extension [TypeScript + Webpack Problem Matchers](https://marketplace.visualstudio.com/items?itemName=amodio.tsl-problem-matcher), or manually do `npm run watch` and click "Debug Anyway."

## Linting

`npm run lint`
Expand Down
13 changes: 13 additions & 0 deletions jest.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// @ts-check

/** @type {import('ts-jest/dist/types').InitialOptionsTsJest} */
module.exports = {
preset: 'ts-jest',
testEnvironment: 'node',
moduleDirectories: ['node_modules', 'src'],
setupFilesAfterEnv: ['<rootDir>/src/test-tools/jest.setup.ts'],
transform: {
'\\.sh$': '<rootDir>/src/test-tools/jest-raw-loader.js',
'\\.yml$': '<rootDir>/src/test-tools/jest-raw-loader.js'
}
};
Loading
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载