-
Notifications
You must be signed in to change notification settings - Fork 6
Add shellcheck for scripts, add dependency injection #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
5c98271
Move some Bash scripts to src/scripts/ and run shellcheck for them
kienstra fbffa9c
Fix the shellcheck errors in get_picard_container()
kienstra 9ebb13a
Strip the #from the scripts
kienstra ed55f48
Add the index.ts file I forgot to stage
kienstra f52c1f0
Fix shellcheck errors in addEnvVars
kienstra 2e88997
Split the bash for docker exec into a script
kienstra a5476bc
See if changing content to any helps
kienstra 6324808
Attempt to get tests to pass with importing envVars.sh
kienstra f81bc59
Revert changes to package.json and package-lock.json
kienstra d5041c6
Add a baseUrl to tsconfig.json and update import statements
kienstra d4f28d4
Fix imports in classes and util functions
kienstra c28930b
Fix linting errors
kienstra 4a39ec8
Move subdirecdtories of src/utils/ into src/
kienstra c65d5ef
Switch to Jest for testing, move a single test to src/cache/test/
kienstra d8af63a
Remove @vscode/test-electron
kienstra 8083a36
Attempt at Inversify, thought it's not working
kienstra c739304
Use inversify for dependency injection, which is working right now
kienstra e2c9fb1
Add shellcheck for linting .sh files
kienstra ed363bd
Move test for getFinalTerminalName() into terminal/test
kienstra fe4c2c2
Merge in develop, resolve conflicts
kienstra a657bf3
Fix linting errors by removing any types
kienstra 5f978f5
Make npm test pass by fixing the return types
kienstra 2d0d0f9
Make tests pass again
kienstra 4674bb6
Stage EnvPath, which I forgot to stage
kienstra 348c8f6
mv types.ts to Types.ts
kienstra 29ee77c
Add a test for the isMac() method, though should probably go in a fil…
kienstra 878d7ba
Move getLogFilePath.spec.ts to log/test/
kienstra c84e0c5
Move getDebuggingTerminalName.test.ts to terminal/
kienstra 36707af
Move getTerminalName.test.ts to terminal/
kienstra 7734d20
Move getFinalTerminalName.test.ts to terminal/
kienstra 161b46a
Add sanitizeLicenseKey test to license/
kienstra c8d637b
Move the test for areTerminalsClosed to terminals/test/
kienstra 00fdd19
Move isTrialExpired() test to license/test/
kienstra 9f19713
Make the moved JobProvider test pass
kienstra 219db82
Add a type for the container
kienstra f4353a2
Use decorator syntax instead of functions
kienstra d3dfe91
Move more tests into their correct files
kienstra 9b519de
Add to tsconfig.json experimentalDecorators: true
kienstra d38d03b
Convert more functions to classes to use dependency injection
kienstra 1899dec
Create an AllJobs file to get all jobs
kienstra a6b40d5
Copy more tests to EnvPath.spec.ts
kienstra 55eaa38
Modify tests in Workspace
kienstra 6b6fc6c
Move the tests for the Email class into Email.spec.ts
kienstra 8aca8bd
Remove an extra line in the EnvPath test
kienstra fb9d8e5
Run jest on all test files
kienstra 5a2227e
Remove binding to singleton scope
kienstra 94d23c9
Convert setBuildAgentSettings to a class
kienstra c99c0ff
Move more test files into their test/ directories
kienstra 3a5495f
Stage files I forgot to stage
kienstra e094440
Merge branch 'develop' into add/shellcheck-and-dependency-injection
kienstra 15ec172
Begin moving the registration of commands to a Registrar class
kienstra f0f6893
Move the *Ioc files to common/
kienstra cb76d82
Fix failing unit tests by fixing the types
kienstra c8988ac
Fix the failed test from EditorGateway
kienstra 38ce08b
Move webview back to src/
kienstra 97c9fbe
Change the JobProviderFactory to a normal class
kienstra 079c174
Change the JobProviderFactory to a normal class
kienstra 205c5f7
Use the factory correctly in extension.ts
kienstra f3a2183
Use the factory correctly in extension.ts
kienstra 67e3488
Create a command for help, and a unit test for it
kienstra 152e0cd
Move the command to select all jobs to command/
kienstra 75ed8c3
Fix some linting errors
kienstra 7c95b98
Create a factory for Registrar
kienstra 8e64d9f
Move showLogFile into a class
kienstra 9dcbd6b
Add handlers to Registrar
kienstra 8a8d2d0
Create a main extension file to activate and deactivate
kienstra 063e652
Add more comamnds to Registrar
kienstra 3c1e352
Change the description of the LocalCi test
kienstra 1d6506f
Move the gateways to a gateway/ directory
kienstra a7add97
Remove webview from src/
kienstra f51e2ec
Move commands/ to command/
kienstra c740486
Move scripts/ to script/
kienstra f2df33b
Fix the bash syntax that didn't get the container
kienstra 0e1f9c0
Strip the shellcheck command
kienstra eedb7f1
Change vscode import to a type import when that's possible
kienstra ee8d7a9
Remove sinon from the repo
kienstra 8260d09
Alphabetize the dependencies in import statements
kienstra af73bf5
Use the helper test function
kienstra fa62294
Convert applyPipelineParameters() to a class
kienstra ea4d074
Move logic to clean up images to script so this can lint it
kienstra 2ce7ea7
Move the Bash syntax to commit the container into a script
kienstra 4a292a2
Remove duplicate test
kienstra 5b4f71a
Use Object.entries() instead of Object.keys()
kienstra 83719cd
Fix linting errors in LoggingProcessGateway
kienstra d33a31f
Will revert: inject the logging gateway
kienstra c5179fa
Remove the conditional for assigning imageIdToExclude
kienstra 942a845
Stop using the LoggingChildProcessGateway
kienstra c0bf6ba
Bump the Node version in the test job
kienstra 8944aac
Remove the last digit in the docker image tag
kienstra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,5 @@ out | |
| dist | ||
| bin | ||
| node_modules | ||
| .vscode-test/ | ||
| *.vsix | ||
| .DS_Store | ||
| .DS_Store | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // @ts-check | ||
|
|
||
| /** @type {import('ts-jest/dist/types').InitialOptionsTsJest} */ | ||
| module.exports = { | ||
| preset: 'ts-jest', | ||
| testEnvironment: 'node', | ||
| moduleDirectories: ['node_modules', 'src'], | ||
| setupFilesAfterEnv: ['<rootDir>/src/test-tools/jest.setup.ts'], | ||
| transform: { | ||
| '\\.sh$': '<rootDir>/src/test-tools/jest-raw-loader.js', | ||
| '\\.yml$': '<rootDir>/src/test-tools/jest-raw-loader.js' | ||
| } | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was where the compiled test files were before.
But now, we don't have to compile the TypeScript before running unit tests.
We'll just run
jest.