+
Skip to content

Fix shellcheck linting issues #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/constants/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ export const GET_RUNNING_CONTAINER_FUNCTION = `get_running_container() {
IMAGE=$1
for container in $(docker ps -q --filter status=running)
do
if [[ $IMAGE == $(docker inspect --format '{{.Config.Image}}' $container) ]]
if [ "$IMAGE" = "$(docker inspect --format '{{.Config.Image}}' "$container")" ]
then
echo $container
echo "$container"
break
fi
done
Expand Down
8 changes: 4 additions & 4 deletions src/utils/runJob.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,13 +145,13 @@ export default async function runJob(
// Once the container is available, run an interactive bash shell within the container.
debuggingTerminal.sendText(`
${GET_RUNNING_CONTAINER_FUNCTION}
echo "You'll get bash access to the job once this conditional is true:\n"
until [[ -n $(get_running_container ${jobImage}) ]]
do
printf "You'll get bash access to the job once this conditional is true:\n"
until [ -n "$(get_running_container ${jobImage})" ]
do
sleep 1
done
echo "Inside the job's container:"
docker exec -it $(get_running_container ${jobImage}) /bin/sh || exit 1`);
docker exec -it "$(get_running_container ${jobImage})" /bin/sh || exit 1`);
debuggingTerminal.sendText('cd ~/');

let finalTerminal: vscode.Terminal;
Expand Down
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载