+
Skip to content

Fix the check for whether Docker is running #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2022
Merged

Fix the check for whether Docker is running #151

merged 1 commit into from
Jul 23, 2022

Conversation

kienstra
Copy link
Member

@kienstra kienstra commented Jul 23, 2022 •
edited
Loading

  • Use docker info instead of docker -v
  • docker -v can pass even if it's not running
  • Now, it shows the warning, as expected:

Screen Shot 2022-07-23 at 3 23 42 PM

Fixes #59

@kienstra
Fix the check for whether Docker is running
dab8e12 
Use docker info instead of docker -v,
which can pass even if it's not running.
@kienstra kienstra merged commit 799c6bd into develop Jul 23, 2022
@kienstra kienstra deleted the fix/docker-error branch September 18, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve or remove Docker error

1 participant

@kienstra
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载