+
Skip to content

Bump the CircleCI® CLI binary versions #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Conversation

kienstra
Copy link
Member

@kienstra kienstra commented Jun 20, 2022

Changes

  • Bump the main binary version to v0.1.18980
  • Use a dynamic version, instead of hard-coded strings

import * as assert from 'assert';
import * as mocha from 'mocha';
import * as sinon from 'sinon';
import * as vscode from 'vscode';
import { Substitute } from '@fluffy-spoon/substitute';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR

@@ -3,32 +3,29 @@ const { Binary } = require('@cloudflare/binary-install');
const { type, arch } = require('os');
const path = require('path');

// File mainly copied from https://github.com/cloudflare/binary-install/blob/a1dc431b2c9b318d21d7f0b2f1abfb27526a2384/packages/binary-install-example/binary.js
function error(msg) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't used anymore

@kienstra kienstra marked this pull request as ready for review June 20, 2022 00:06
@kienstra kienstra merged commit 2eca4b2 into develop Jun 20, 2022
@kienstra kienstra deleted the bump/binary-version branch June 20, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载