+
Skip to content

Fix a bug where this didn't get the right binary for other platforms #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2022
Merged

Fix a bug where this didn't get the right binary for other platforms #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions node/binary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,23 +55,8 @@ function getBinaryPath() {
);
}

function getBinaryUrl() {
const supportedPlatform = getSupportedPlatform();

if (supportedPlatform) {
return supportedPlatform.url;
}

error(
`Platform with type "${platformType}" and architecture "${architecture}" is not supported.\nYour system must be one of the following:\n\n${cTable.getTable(
supportedPlatforms
)}`
);
}

function getBinary(platform) {
const url = getBinaryUrl();
return new Binary(url, {
return new Binary(platform.url, {
name: "cirlceci",
installDirectory: path.join(
__dirname,
Expand Down
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载