+
Skip to content

Fix a bug where this didn't get the right binary for other platforms #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2022
Merged

Fix a bug where this didn't get the right binary for other platforms #129

merged 1 commit into from
May 30, 2022

Conversation

kienstra
Copy link
Member

@kienstra kienstra commented May 30, 2022 •
edited
Loading

Changes

  • Fix a bug where this didn't get the right binary for other platforms
  • It unexpectedly installed the same binary for all 4 versions:
Downloading release from https://github.com/CircleCI-Public/circleci-cli/releases/download/v0.1.17087/circleci-cli_0.1.17087_darwin_amd64.tar.gz
Downloading release from https://github.com/CircleCI-Public/circleci-cli/releases/download/v0.1.17087/circleci-cli_0.1.17087_darwin_amd64.tar.gz
Downloading release from https://github.com/CircleCI-Public/circleci-cli/releases/download/v0.1.17087/circleci-cli_0.1.17087_darwin_amd64.tar.gz
Downloading release from https://github.com/CircleCI-Public/circleci-cli/releases/download/v0.1.17087/circleci-cli_0.1.17087_darwin_amd64.tar.gz
cirlceci has been installed!
cirlceci has been installed!
cirlceci has been installed!
cirlceci has been installed!

@kienstra kienstra merged commit 9614491 into develop May 30, 2022
@kienstra kienstra deleted the fix/bug-binary-version branch May 30, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kienstra
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载