+
Skip to content

Add a confirmation dialog to run a job #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 16, 2022

Conversation

kienstra
Copy link
Member

@kienstra kienstra commented Mar 16, 2022

Background

A user had a great point that people might not expect it to run the job on clicking it. It's common to click a file in VS Code, and nothing happens when you click it, other than showing the file.

Changes

  • On clicking a job, this opens a dialog:
    clicking-confirm
  • The job only runs on clicking 'Yes', or if they've clicked "Don't ask again"
  • This could still be improved, maybe it shouldn't be a dialog, or maybe the dialog should have more options, like to set env vars

@kienstra kienstra marked this pull request as ready for review March 16, 2022 15:35
@kienstra
Copy link
Member Author

This could still use improvement, but merging now.

@kienstra kienstra merged commit 5b4c489 into develop Mar 16, 2022
@kienstra kienstra deleted the add/confirmation-to-run-job branch March 16, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载