+
Skip to content

Stop committing images, add more helpful messages #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 8, 2022

Conversation

kienstra
Copy link
Member

@kienstra kienstra commented Jan 7, 2022

Changes

  • Stop committing images when the job succeeds or fails
  • Add several helper notices, like for internet connection:
    Screen Shot 2022-01-06 at 5 25 55 PM

There's no need to keep committing,
as the job isn't running anymore.
The data can start with M, like:
M .circleci/config.yml
so .startsWith('.circleci/config.yml')
will be false.
There could be a non-Local CI terminal that closes,
and that shouldn't trigger killing the commitProcess.
There could have been a bug
where job.getName()
no longer returned a name.
Instead of the hack of ending the message
with ' ' before concatenation.
@kienstra kienstra merged commit 27e0250 into develop Jan 8, 2022
@kienstra kienstra deleted the add/message-to-fix-build branch January 8, 2022 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载