+
Skip to content

Make a dynamic config error recoverable #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 6, 2022
Merged

Conversation

kienstra
Copy link
Member

@kienstra kienstra commented Jan 6, 2022

Changes

  • Make it easier if there was an error in a generated config
  • Changes the 'Try Again' button to delete the config file if there is one:
    Screen Shot 2022-01-06 at 11 22 09 AM

Sometimes there will be no dynamic jobs,
like if there's no diff against main.
So show a more helpful message,
instead of
Success! You can now run the dynamic config jobs
When there's an error in the generated dynamic config,
sometimes the only way to fix it is to
delete that config.
Then, the user can rerun the setup job.
Maybe LCI should do that for them,
but that might be overstepping.
There would still be a problem running a
job in a config that doesn't exist,
but that probably isn't the place to fix it.
@kienstra kienstra marked this pull request as ready for review January 6, 2022 17:30
@kienstra kienstra merged commit 1a711d7 into develop Jan 6, 2022
@kienstra kienstra deleted the fix/dynamic-config-file branch January 6, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载