+
Skip to content

Support save_cache and restore_cache #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Dec 15, 2021
Merged

Support save_cache and restore_cache #53

merged 22 commits into from
Dec 15, 2021

Conversation

kienstra
Copy link
Member

@kienstra kienstra commented Dec 6, 2021

Changes

  • Before, this simply ignored save_cache and restore_cache
  • Now, this caches and restores the cache when there is a cache

Screen Shot 2021-12-15 at 12 17 38 AM

It should commit in an infinite loop
until Node exits from it.
Before, copying /tmp/local-ci/foo/* didn't work
if it had dotfiles or directories,
like .cache.
There was a conflict in
getAttachWorkspaceCommand.test.ts
This should help to
restore the cache,
as it'll show the paths that it used.
It still needs to handle keys,
not just key.
It shouldn't always save the cache,
like if the cache already exists.
@@ -0,0 +1,139 @@
version: 2.1
Copy link
Member Author

@kienstra kienstra Dec 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mainly copied from https://github.com/kefranabg/bento-starter/blob/c5ec78a033d3915d700bd6463594508098d46448/.circleci/config.yml so that this tests a real .circleci/config.yml file

@kienstra kienstra marked this pull request as ready for review December 15, 2021 08:02
@kienstra kienstra merged commit 802d28f into develop Dec 15, 2021
@kienstra kienstra deleted the add/restore-cache branch May 5, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载