-
Notifications
You must be signed in to change notification settings - Fork 6
Offer a longer trial for filling out a short survey #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
dc69b53
Change the remaining time in the preview to account for days
kienstra e853d38
Extend the trial by 15 days on filling out the survey
kienstra 9aefcd2
Remove = before Node version
kienstra a2abc58
Bump vscode-test to the latest
kienstra 731fd36
Have an hour count at less than 2 days
kienstra 8bcf36b
If there's less than a minute remaining, show 'No time'
kienstra a6053db
Prevent a JS error in addLicenseHandlers()
kienstra fdddfc3
Always show the hours if there are any after days
kienstra 53ce8ad
Close the <p> tag, add a dynamic number of days
kienstra 3f49b25
Change the <a> to a <button>
kienstra 9b4023c
Round the hours up, so it doesn't show 1 day, 23 hours right away
kienstra d622b72
Rename daysInMilliseconds to be singular
kienstra dd9d47a
Prevent a decimal hours count
kienstra cecbf8c
Add a link for a research interview
kienstra efa66d5
Add a 'Complain' link, thanks to Jason Cohen's idea
kienstra 676979e
Remove needless const, rearrange destructuring
kienstra 13cc312
Change the URL to book a meeting
kienstra 38ce98c
Add the survey URL
kienstra 93e015c
Bump the version to 1.0.2
kienstra 7fb93fa
Fix the link to do the interview
kienstra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
node | ||
16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
50 changes: 50 additions & 0 deletions
50
src/test/suite/utils/getMillisecondsRemainingInTrial.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import * as assert from 'assert'; | ||
import { TRIAL_LENGTH_IN_MILLISECONDS } from '../../../constants'; | ||
import getMillisecondsRemainingInTrial from '../../../utils/getMillisecondsRemainingInTrial'; | ||
|
||
const hourInMilliseconds = 3600000; | ||
suite('getMillisecondsRemainingInTrial', () => { | ||
test('entire trial remaining', () => { | ||
const time = new Date().getTime(); | ||
assert.strictEqual( | ||
getMillisecondsRemainingInTrial(time, time, TRIAL_LENGTH_IN_MILLISECONDS), | ||
172800000 | ||
); | ||
}); | ||
|
||
test('1 day remaining', () => { | ||
const time = new Date().getTime(); | ||
assert.strictEqual( | ||
getMillisecondsRemainingInTrial( | ||
time, | ||
time - 24 * hourInMilliseconds, | ||
TRIAL_LENGTH_IN_MILLISECONDS | ||
), | ||
86400000 | ||
); | ||
}); | ||
|
||
test('1 hour remaining', () => { | ||
const time = new Date().getTime(); | ||
assert.strictEqual( | ||
getMillisecondsRemainingInTrial( | ||
time, | ||
time - 47 * hourInMilliseconds, | ||
TRIAL_LENGTH_IN_MILLISECONDS | ||
), | ||
3600000 | ||
); | ||
}); | ||
|
||
test('no time remaining', () => { | ||
const time = new Date().getTime(); | ||
assert.strictEqual( | ||
getMillisecondsRemainingInTrial( | ||
time, | ||
time - 48 * hourInMilliseconds, | ||
TRIAL_LENGTH_IN_MILLISECONDS | ||
), | ||
0 | ||
); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was hacky, it's replaced with the
globalState.update()
above