+
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: getlocalci/local-ci
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.4.3
Choose a base ref
...
head repository: getlocalci/local-ci
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.4.4
Choose a head ref
  • 17 commits
  • 29 files changed
  • 1 contributor

Commits on Jan 8, 2022

  1. Move error notice out of failure conditional 

    The string didn't have 'Task failed'
when testing this.
    @kienstra
    kienstra committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    c6e2cf0 View commit details
    Browse the repository at this point in the history

  2. Prevent an error if there are no jobs 

    Some configs have no job, like:
https://github.com/jeffreychuuu/kotlin_example_app/blob/cdf49347147e578442effd81accdb84412024389/.circleci/config.yml

Those are still valid when doing:
circleci config validate
So Local CI should process those configs without error.
    @kienstra
    kienstra committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    6a31765 View commit details
    Browse the repository at this point in the history

  3. Prevent an error if the job name has a space, like Decision Making 

    https://github.com/jeffreychuuu/kotlin_example_app/blob/cdf49347147e578442effd81accdb84412024389/.circleci/config.yml#L9
    @kienstra
    kienstra committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    a82b059 View commit details
    Browse the repository at this point in the history

  4. Prevent an error where parsedProcessFile.jobs is undefined

    @kienstra
    kienstra committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    8bdf9b2 View commit details
    Browse the repository at this point in the history

  5. Prevent a TypeScript error from an Object possibly being undefined

    @kienstra
    kienstra committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    2bbd342 View commit details
    Browse the repository at this point in the history

  6. Move checkout to the top of the steps in config.yml

    @kienstra
    kienstra committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    cd12883 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Only process the config(s) when needed

    @kienstra
    kienstra committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    90d87e5 View commit details
    Browse the repository at this point in the history

  2. Change suppressMessage from a property to an argument 

    It might as well go to loadJobs()
as an argument,
as that's the only function that uses it.
    @kienstra
    kienstra committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    61992c9 View commit details
    Browse the repository at this point in the history

  3. Rename suppressMessage to skipMessage 

    The 1st parameter is skipConfigProcessing,
so this might follow that convention better.
    @kienstra
    kienstra committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    5160a25 View commit details
    Browse the repository at this point in the history

  4. Remove needless properties that were just used in 1 function 

    Make them variables,
declared with let.
    @kienstra
    kienstra committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    ca50729 View commit details
    Browse the repository at this point in the history

  5. Rename suppressMessage in JobProvider.refresh() also

    @kienstra
    kienstra committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    1fdaa93 View commit details
    Browse the repository at this point in the history

  6. Change the name of the env var step to show it sets more than 1 var 

    Instead of Set CIRCLE_SHA1,
Set more
    @kienstra
    kienstra committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    9e93414 View commit details
    Browse the repository at this point in the history

  7. Create a const of dynamic config path in the container

    @kienstra
    kienstra committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    8487efa View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. Update comments for latest changes

    @kienstra
    kienstra committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    97af721 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Improve support for dynamic configs, mainly the continuation orb

    @kienstra
    kienstra committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    87784ee View commit details
    Browse the repository at this point in the history

  2. Use path to create the process file directory

    @kienstra
    kienstra committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    9688bd1 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. Merge pull request #75 from getlocalci/fix/error-messages 

    Prevent errors, like from no jobs
    @kienstra
    kienstra authored Jan 14, 2022
    Configuration menu
    Copy the full SHA
    f2f1564 View commit details
    Browse the repository at this point in the history
Loading
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载