Fixed app crash in rank widget issue (#2742) on config change. #2746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
requested changes
Dec 4, 2018
collect_app/src/main/java/org/odk/collect/android/fragments/dialogs/RankingWidgetDialog.java
Outdated
Show resolved
Hide resolved
|
Tested with success Verified on Android: 4.1, 4.4, 5.1, 6.0, 7.0, 8.1 @opendatakit-bot label "behavior verified" |
grzesiek2010
approved these changes
Dec 4, 2018
yanokwa
pushed a commit
that referenced
this pull request
Dec 4, 2018
* Fix app crash in rank widget issue (#2742) on config change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2742
What has been done to verify that this works as intended?
Tested on local device Moto G5 Plus
Why is this the best possible solution? Were any other approaches considered?
Adopts best practices for Saving and Retrieving Instances
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
None
Do we need any specific form for testing your changes? If so, please attach one.
Nope
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.