+
Skip to content

Conversation

yantosca
Copy link
Contributor

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Describe the update

This PR does the following:

  1. Changes mamba to conda in the benchmark/benchmark_slurm.sh script, as Mamba is now deprecated.
  2. Separates the benchmark plot and benchmark table options with comments in the YAML files in benchmark/config and benchmark/cloud.
  3. Also separates the plot commands for special collections and makes it clear that these are not normally used for benchmarks.
  4. Activates plot_drydep: True in 1yr_fullchem_benchmark.yml as we now turn on the DryDep collection.

Expected changes

No changes are expected, other than the DryDep plots will now be included in 1-year fullchem benchmark output.

gcpy/benchmark/benchmark_slurm.sh
- Change "mamba" commands to "conda", since Mamba is now deprecated

gcpy/benchmark/cloud/*.yml
gcyp/benchmark/config/*.yml
- Separate benchmark plot and benchmark table options, for clarity
- Separate the plot options for special collections
- Activate plot_drydep:True in 1yr_fullchem_benchmark.yml
- Update comments

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca requested a review from msulprizio October 14, 2025 20:17
@yantosca yantosca self-assigned this Oct 14, 2025
@yantosca yantosca added category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output topic: Structural Modifications Related to GCPy structural modifications (as opposed to scientific updates) labels Oct 14, 2025
@yantosca yantosca added this to the 1.7.0 milestone Oct 14, 2025
gcpy/benchmark/benchmark_slurm.sh
- Removed a stray "x"

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca requested a review from msulprizio October 15, 2025 13:52
Copy link
Contributor

@msulprizio msulprizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge now. Thanks!

@yantosca yantosca merged commit e4a2698 into dev Oct 15, 2025
@yantosca yantosca deleted the feature/update-benchmark-config branch October 15, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output topic: Structural Modifications Related to GCPy structural modifications (as opposed to scientific updates)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载