Update the "end of search" criteria in benchmark_scrape_classic_timers.py to avoid being spoofed by output from Intel VTune #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcpy/benchmark/modules/benchmark_scrape_gcclassic_timers.py - Updated the marker that denotes when to stop reading from a GEOS-Chem Classic log file from "----------" to "-"*78 (that is, 78 dashes in a row). This is necessary in order to prevent text appended by Intel VTune to the end of a GEOS-Chem log file from interfering with the scraping of the timers. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
msulprizio
approved these changes
Jun 26, 2025
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
In
gcpy/benchmark/modules/benchmark_scrape_gcclassic.timers.py, the code starts reading the timers information backwards from the end of the file. The signal to stop reading was if a line contained----------. However, when output from the Intel VTune profiler is appended to the end of a GEOS-Chem Classic log file, there is a line with at least many-characters, which causes the parsing of the file to end before the timing information is reached.The solution is to change the criteria to look for a line with 78
-characters in a row (which occurs just beforeGEOS-Chemtimer row. This will allow the parsing of the log file to proceed normally.NOTE: This is not an issue when
benchmark_scrape_gcclassic_timers.pyreads thegcclassic_timers.jsonfile.Expected changes
This will allow
benchmark_scrape_gcclassic_timers.pyto be able to read the GEOS-Chem timing information from log files where Intel VTune has appended a report to the end of the file.