Add benchmark diagnostic sanity check table #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcpy/benchmark/modules/benchmark_funcs.py - Added routine create_benchmark_sanity_check_table to print a table showing which diagnostic variables are all zero or all NaN. This can help to identify diagnostic issues in benchmarks. gcpy/benchmark/run_benchmark.py - Call create_benchmark_sanity_check_table (for GCC vs GCC and GCHP vs GCHP only). cloud/template.1hr_benchmark.yml cloud/template.1mo_benchmark.yml config/1mo_benchmark.yml - Add sanity_check_table tag to "options:" menu. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
lizziel
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
This PR adds a sanity check table to the 1-hr and 1-month benchmark outputs that will aid in identifying errors in diagnostics.
Function
create_benchmark_sanity_check_tablehas been added togcpy.benchmark.modules.benchmark_funcs, and is called fromgcpy.benchmark.run_benchmark.Expected changes
The following benchmark table output will be generated.