Fix incorrect species classification in benchmark_categories.yml #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcpy/benchmark/modules/benchmark_categories.yml - Moved HACTA, HCOOH, MAP, RCOOH to "Secondary_Organics:Acids" - Moved GLYC, GLYX, RCHO to "Secondary_Organics:Aldehydes" - Added TLFUONE to "Secondary_Organics:Other" CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
msulprizio
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
This PR fixes some incorrect species clarifications in the
gcpy.benchmark.modules.benchmark_categories.yml. This YAML file determines how species are grouped into different PDFs (for theSpeciesConcVVplots only).Based on feedback from @ktravis213 we have made the following updates:
Secondary_Organics:AcidsSecondary_Organics:AldehydesSecondary_Organics:OtherExpected changes
This will now place the affected species in the proper PDF file.
Reference(s)
If this is a science update, please provide a literature citation.
Related Github Issue
Tagging @ktravis213 @kelvinhb