Peg xarray to version 2023.2.0 in the environment.yml file #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/environment_files/environment.yml - The latest xarray (2023.8.0) seems to have some under-the-hood shenanigans with dask that break the benchmark plotting capability. For the time being, peg xarray to 2023.2.0, which seems to avoid this behavior. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
|
Fixes #254 |
msulprizio
approved these changes
Aug 29, 2023
yantosca
added a commit
that referenced
this pull request
Aug 29, 2023
docs/environment_files/environment.yml - In the prior commit we have added updates to plot.py that render the pegging of xarray to version 2023.2.0 unnecessary. Restore the original code in the GCPy environment.yml file. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added a commit
that referenced
this pull request
Aug 30, 2023
This merge brings PR #257 (Update plot.py for more recent xarray; also allow dask arrays to be passed to single_panel, six_plot routines, by @yantosca) into the GCPy 1.4.0 development stream. This PR does the following: 1. Now use "ds_new[lon_var].compute()" and "ds_new[lat_var].compute()" to evaluate the lon_var and lat_var fields. This behavior is now necessary in the latest xarray (2023.8.0). 2. Allow routines "six_plot" and "single_panel" in gcpy/plot.py to also accept dask arrays (dask.array.Array) 3. Updated documentation 4. Reverted the update to environment.yml from PR #255; now allow latest xarray in the Python environment. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pegs the xarray version at 2023.2.0 in the environment file
docs/environment_files/environment.yml. This is because the most recent version (2023.8.0) seems to have some under-the-hood shenanigans withdaskthat breaks backwards compatibility with the benchmark plotting scripts.This is a temporary measure intended to give us a little more time to figure out what code modifications are needed so that GCPy can work with the latest xarray.