+
Skip to content

Conversation

laestrada
Copy link
Contributor

This PR adds the templates needed for cloud benchmarking into the gcpy source code. These files should be updated as the requirements for running gcpy evolve.

@laestrada laestrada requested a review from yantosca May 25, 2023 22:00
@laestrada laestrada changed the base branch from main to dev May 25, 2023 22:00
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @laestrada! This PR is good to merge.

CHANGELOG.md
- Added note that cloud benchmarking template files are now stored
  in the benchmark/cloud folder.  This is so that we keep all
  benchmark config files within GCPy.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca added the category: Feature Request New feature or request label May 26, 2023
@yantosca yantosca added this to the 1.4.0 milestone May 26, 2023
@yantosca yantosca self-assigned this May 26, 2023
@yantosca yantosca merged commit 257a50e into dev May 26, 2023
@yantosca yantosca deleted the feature/benchmark_cloud_plotting_templates branch May 26, 2023 12:56
@yantosca
Copy link
Contributor

Thanks @laestrada! Now merged into the dev branch.

hannahnesser pushed a commit to hannahnesser/gcpy that referenced this pull request Jan 22, 2024
This merge brings PR geoschem#223 by @laestrada into the GCPy 1.4.0 development
stream.  It brings the files `template.1hr_benchmark.yml` and
`template.1mo_benchmark.yml` into GCPy from the gc-cloud-infrastructure
repository.  This allows all of the benchmark configuration files to be
kept within GCPy, which makes it less likely to forget to make updates
in both the GCPy and gc-cloud-infrastructure repositories.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: Feature Request New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载