+
Skip to content

Update SpeciesConc variable name to SpeciesConcVV for consistency with GEOS-Chem 14.1.0 updates #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

msulprizio
Copy link
Contributor

In GEOS-Chem 14.1.0, the SpeciesConc collection may now be saved out with variable names SpeciesConcVV or SpeciesConcMND. To allow for comparison with output from earlier versions, we now rename SpeciesConc to SpeciesConcVV within benchmark.py.

See corresponding GEOS-Chem PR geoschem/geos-chem#1572

…h GEOS-Chem 14.1.0 updates

In GEOS-Chem 14.1.0, the SpeciesConc collection may now be saved out with
variable names SpeciesConcVV or SpeciesConcMND. To allow for comparison
with output from earlier versions, we now rename SpeciesConc to SpeciesConcVV
within benchmark.py.

See corresponding GEOS-Chem PR geoschem/geos-chem#1572

Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
@msulprizio msulprizio added the topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output label Dec 22, 2022
@msulprizio msulprizio added this to the 1.3.0 milestone Dec 22, 2022
@msulprizio msulprizio requested a review from yantosca December 22, 2022 18:04
@msulprizio msulprizio self-assigned this Dec 22, 2022
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor typos but otherwise good to merge.

As @yantosca points out in his review, `Species_Conc` should be 'SpeciesConc_'.

Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
@msulprizio msulprizio requested a review from yantosca December 22, 2022 18:32
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Thanks @msulprizio!!!

@msulprizio msulprizio merged commit ae12821 into dev Dec 22, 2022
@msulprizio msulprizio deleted the feature/speciesconc_update branch December 22, 2022 19:35
@msulprizio msulprizio modified the milestones: 1.3.0, 1.4.0 Dec 22, 2022
@yantosca yantosca modified the milestones: 1.4.0, 1.3.3 Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载