-
Notifications
You must be signed in to change notification settings - Fork 26
Comparing changes
Open a pull request
base repository: geoschem/gcpy
base: main
head repository: geoschem/gcpy
compare: dev
- 10 commits
- 7 files changed
- 2 contributors
Commits on Jun 25, 2025
-
Add vtune_plot_hotspots.py, based on gprofng_functions.py
gcpy/plot/core.py - Moved function "gprofng_text_to_data_units" (from module "gprofng_functions") to this module as "text_to_data_units". This will make it available as a general plotting function. gcpy/profile/gprofng_functions.py - Import "text_to_data_units" from "gcpy.plot.core" - Fixed incorrect error message string gcpy/profile/vtune_plot_hotspots - Added this function to create a bargraph from Intel VTune hotspot reports. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 53d2690 - Browse repository at this point
Copy the full SHA 53d2690View commit details -
Add RTD doc for plotting hotspots from Intel VTune
docs/source/Code-Profiling.rst - Added a section describing how to plot hotspots with gcpy.profile.vtune_plot_hotspots. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 8c37b18 - Browse repository at this point
Copy the full SHA 8c37b18View commit details -
Drop certain system calls from being plotted by vtune_plot_hotspots.py
gcpy/profile/vtune_plot_hotspots.py - Skip plotting entries such as "wait.h", "mutex.c", etc, as these can have multiple entries in an Intel VTune report, which will confuse the bargraph plotting. We mostly care about user routines that can be modified to save time, rather than system calls. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 857bbe8 - Browse repository at this point
Copy the full SHA 857bbe8View commit details -
Prevent VTune output from spoofing benchmark_scrape_gcclassic_timers
gcpy/benchmark/modules/benchmark_scrape_gcclassic_timers.py - Updated the marker that denotes when to stop reading from a GEOS-Chem Classic log file from "----------" to "-"*78 (that is, 78 dashes in a row). This is necessary in order to prevent text appended by Intel VTune to the end of a GEOS-Chem log file from interfering with the scraping of the timers. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for fed4082 - Browse repository at this point
Copy the full SHA fed4082View commit details
Commits on Jun 26, 2025
-
This merge brings PR # (Update the "end of search" criteria in benchmark_scrape_classic_timers.py to avoid being spoofed by output from Intel VTune, by @yantosca) into the GCPy development stream. In gcpy/benchmark/modules/benchmark_scrape_gcclassic.timers.py, the code starts reading the timers information backwards from the end of the file. The signal to stop reading was if a line contained "----------". However, when output from the Intel VTune profiler is appended to the end of a GEOS-Chem Classic log file, there is a line with at least as many "-" characters, which causes the parsing of the file to end before the timing information is reached. The solution is to change the criteria to look for a line with 78 "-" characters in a row (which occurs just before GEOS-Chem timer row. This will allow the parsing of the log file to proceed normally. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 5deccdc - Browse repository at this point
Copy the full SHA 5deccdcView commit details -
Merge PR #364 (Add script to plot hotspots from Intel VTune reports)
This merge brings PR #364 (Add script to plot hotspots from Intel VTune reports, by @yantosca) into the GCPy development stream. PR #364 does the following: 1. Adds gcpy/profile/vtune_plot_hotspots.py, which can create bargraph plots (similar to gprofng_functions.py) from hotspot reports from Intel VTune. This tool accepts hotspot reports listed by function and by line. 2. Moves the gprofng_text_to_data_units functions out of gcpy/profile/gprofng_functions.py to gcpy/plot/core.py, so that it can be used as a generic plotting function. 3. Updates ReadTheDocs documentation in docs/source/Code-Profiling.rst accordingly. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 4764def - Browse repository at this point
Copy the full SHA 4764defView commit details
Commits on Jul 14, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 4b98df7 - Browse repository at this point
Copy the full SHA 4b98df7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b2a596 - Browse repository at this point
Copy the full SHA 9b2a596View commit details -
Configuration menu - View commit details
-
Copy full SHA for 903c9cc - Browse repository at this point
Copy the full SHA 903c9ccView commit details
Commits on Jul 16, 2025
-
Hotfix: Remove duplicate entries for GCPy 1.6.2 in CHANGELOG.md
CHANGELOG.md - Removed duplicated entries for version 1.6.2. These were probably a result of Git automatic merges. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for b7212f1 - Browse repository at this point
Copy the full SHA b7212f1View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...dev