-
Notifications
You must be signed in to change notification settings - Fork 26
Comparing changes
Open a pull request
base repository: geoschem/gcpy
base: 1.4.1
head repository: geoschem/gcpy
compare: 1.4.2
- 14 commits
- 17 files changed
- 1 contributor
Commits on Jan 25, 2024
-
Add create_test_plot script; can check if GCPy is installed properly
gcpy/examples/plotting/create_test_plot.py - Script to create a dummy plot that renders to the screen. Useful for checking if "import gcpy" works properly. gcpy/examples/plotting/__init__.py - Added create_test_plot.py CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 1c986de - Browse repository at this point
Copy the full SHA 1c986deView commit details -
Add GitHub action "build-gcpy-environment"
.github/workflows/build-gcpy-environment.yml - Added this configuration file for the "build-gcpy-environment" GitHub action. This runs on pushes or PRs made to the main or dev branches. The PR will use setup-micromamba to build the gcpy environment, import gcpy, and call a simple plotting script. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 730cb82 - Browse repository at this point
Copy the full SHA 730cb82View commit details -
Add GitHub action to build the GCPy python environment
.github/workflows/build-gcpy-environment.yml - Add configuration file to trigger a GitHub action on pushes to main,dev or PRs to main,dev. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 5afddd3 - Browse repository at this point
Copy the full SHA 5afddd3View commit details -
Merge PR #286 (Add GitHub action to build GCPy env)
This merge brings PR #286 (Add GitHub action to build GCPy environment and test installation, by @yantosca) into the GCPy 1.4.2 development stream. This adds a GitHub action to check if the GCPy environment (as specified in the "environment.yml" file) will build properly, and if the "import gcpy" command works. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 1fb87e4 - Browse repository at this point
Copy the full SHA 1fb87e4View commit details -
Prevent overwriting the "results" variable when parallelization is off.
This commit fixes the issue reported by @lizziel in #285. The "results" variable was being overwritten instead of appended to when plots are generated sequentially (i.e. with "n_cores: 1" in the YAML input). gcpy/benchmark/modules/run_1yr_*_fullchem.py gcpy/benchmark_funcs.py gcpy/plot/compare_*.py - For the case when parallelization is off: 1. Declare "results" as an empty list 2. Append the output of the routine being called into "results" This will prevent a dictionary key error as described in #285. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 0252fc5 - Browse repository at this point
Copy the full SHA 0252fc5View commit details -
gcpy/benchmark_funcs.py - Removed a leftover print statement and quit() statement from debugging Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 7a2c321 - Browse repository at this point
Copy the full SHA 7a2c321View commit details -
Update environment.yml file to use pegged versions
docs/environment_files/environment.yml - Now use pegged package versions, as described in issue #284 Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 1e4a090 - Browse repository at this point
Copy the full SHA 1e4a090View commit details -
Add test environment file; Add new GitHub action
docs/environment_files/testing.yml - Add this new environment file, based on the environment.yml file, but without pegged version numbers for most packages. .github/workflows/build-test-environment.yml - YAML config file to start a new GitHub action to build the mamba environment from "testing.yml" .github/workflows/build-gcpy-environment.yml - Updated names and comments - Now read docs/environment_files/environment.yml CHANGEKOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 1a67236 - Browse repository at this point
Copy the full SHA 1a67236View commit details
Commits on Jan 26, 2024
-
build-gcpy-environment now tests env build w/ several Python versions
.github/workflows/build-gcpy-environment - Now attempt to build the environment with Python versions 3.8 thru 3.13. CHANGELOG.md - Updated currently Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 8595565 - Browse repository at this point
Copy the full SHA 8595565View commit details -
Merge PR #287 (Fix dictionary key error for non-parallel plotting)
This merge brings PR # (Fix dictionary key error when benchmark plots are generated sequentially, by @yantosca) into the GCPy 1.4.2 development stream. This fixes an error where a dictionary was not being properly appended into a list in the benchmark plotting code, when parallel plotting was disabled. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for a8c8b7d - Browse repository at this point
Copy the full SHA a8c8b7dView commit details -
Fix typo in testing.yml; peg versions for RTD packages
docs/environment_files/testing.yml - Fixed typo: "environmet" -> "environment" in comments - Now peg the RTD package versions, as we know these work. - Also peg matplotlib>=3.8 Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 43c783a - Browse repository at this point
Copy the full SHA 43c783aView commit details -
Merge PR #289 (Use pegged versions in environment etc.)
This merge brings PR # (Use pegged version numbers for the GCPy environment; Also add testing environment without pegged versions; Updated GitHub actions, by @yantosca) into the 1.4.2 development stream. This changes the default environment.yml to use pegged version numbers in order to avoid build issues. This now builds the GCPy environment much faster. The GitHub action that tests the environment build now uses a matrix of different Python versions. Also added a testing.yml file to specify an experimental GCPy environment for use in GitHub actions. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 1dffa6c - Browse repository at this point
Copy the full SHA 1dffa6cView commit details -
Update version numbers and prepare for GCPy 1.4.2 release
CHANGELOG.md docs/source/conf.py gcpy/_version.py gcpy/benchmark/run_benchmark.py gcpy/benchmark/modules/run_1yr_fullchem_benchmark.py gcpy/benchmark/modules/run_1yr_tt_benchmark.py CHANGELOG.md - Updated version numbers setup.py - Restored, now use same version numbers as in environment.yml Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Configuration menu - View commit details
-
Copy full SHA for 70d649a - Browse repository at this point
Copy the full SHA 70d649aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bd730f - Browse repository at this point
Copy the full SHA 4bd730fView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1.4.1...1.4.2