chore: update to cmake 3.10, enforce formatting with tooling #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly a starting point so we can start enforcing formatting with tooling.
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the build system and enforces consistent code formatting by updating to CMake 3.10 and introducing clang-format tooling with automated CI formatting checks.
- Updates minimum CMake version from 3.5 to 3.10
- Adds clang-format configuration file and optional build targets for format checking/fixing
- Implements GitHub Actions CI workflow to build the project and verify formatting
Reviewed Changes
Copilot reviewed 20 out of 22 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CMakeLists.txt | Updates minimum CMake version and adds optional clang-format targets |
| .clang-format | Defines code formatting rules based on LLVM style |
| .github/workflows/linux.yml | Adds CI workflow for building and format checking |
| src/.h, src/.cpp | Applies clang-format styling to all source files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
3.10as minimum version.clang-formatfileclang-formatCloses #130